[
https://issues.apache.org/jira/browse/METRON-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103913#comment-16103913
]
ASF GitHub Bot commented on METRON-777:
---------------------------------------
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/530
In bundles-lib/, possibly incorrect usages of nar, which should -> bundle:
```
bundles-lib//src/main/java/org/apache/metron/bundles/bundle/BundleDetails.java:
* Builder for NarDetails.
bundles-lib//src/main/java/org/apache/metron/bundles/BundleClassLoaders.java:
// load the bundle details which includes and nar dependencies
[grammar?]
bundles-lib//src/main/java/org/apache/metron/bundles/BundleClassLoaders.java:
logger.warn(String.format("While loading '%s' unable to locate exact NAR
dependency '%s'. Only found one possible match '%s'. Continuing...",
bundles-lib//src/main/java/org/apache/metron/bundles/ExtensionManager.java:
// The NAR system uses the ServiceLoader, but this chokes on
abstract classes, because for some
```
Test subdirectory:
```
bundles-lib//src/test/java/org/apache/metron/bundles/BundleUtilTest.java:
assertEquals("nifi-hadoop-nar", bundleDetails.getCoordinate().getId());
bundles-lib//src/test/java/org/apache/metron/bundles/BundleUtilTest.java:
assertEquals("nifi-hadoop-libraries-nar",
bundleDetails.getDependencyCoordinate().getId());
bundles-lib//src/test/java/org/apache/metron/bundles/BundleUtilTest.java:
assertEquals("nifi-hadoop-nar", bundleDetails.getCoordinate().getId());
bundles-lib//src/test/java/org/apache/metron/bundles/BundleUtilTest.java:
assertEquals("nifi-hadoop-libraries-nar",
bundleDetails.getDependencyCoordinate().getId());
bundles-lib//src/test/java/org/apache/metron/bundles/BundleUtilTest.java:
assertEquals("nifi-hadoop-nar", bundleDetails.getCoordinate().getId());
bundles-lib//src/test/resources/bundle.properties:bundle.meta.id.prefix=Nar
bundles-lib//src/test/resources/BundleUnpacker/conf/bundle.properties:bundle.meta.id.prefix=Nar
bundles-lib//src/test/resources/utils-bundles/bundle-with-versioning/META-INF/MANIFEST.MF:Nar-Group:
org.apache.nifi
bundles-lib//src/test/resources/utils-bundles/bundle-with-versioning/META-INF/MANIFEST.MF:Nar-Id:
nifi-hadoop-nar
bundles-lib//src/test/resources/utils-bundles/bundle-with-versioning/META-INF/MANIFEST.MF:Nar-Version:
1.2.0
bundles-lib//src/test/resources/utils-bundles/bundle-with-versioning/META-INF/MANIFEST.MF:Nar-Dependency-Group:
org.apache.nifi.hadoop
bundles-lib//src/test/resources/utils-bundles/bundle-with-versioning/META-INF/MANIFEST.MF:Nar-Dependency-Id:
nifi-hadoop-libraries-nar
bundles-lib//src/test/resources/utils-bundles/bundle-with-versioning/META-INF/MANIFEST.MF:Nar-Dependency-Version:
1.2.1
bundles-lib//src/test/resources/utils-bundles/bundle-without-dependency/META-INF/MANIFEST.MF:Nar-Group:
org.apache.nifi
bundles-lib//src/test/resources/utils-bundles/bundle-without-dependency/META-INF/MANIFEST.MF:Nar-Id:
nifi-hadoop-nar
bundles-lib//src/test/resources/utils-bundles/bundle-without-dependency/META-INF/MANIFEST.MF:Nar-Version:
1.2.0
bundles-lib//src/test/resources/utils-bundles/bundle-without-versioning/META-INF/MANIFEST.MF:Nar-Id:
nifi-hadoop-nar
bundles-lib//src/test/resources/utils-bundles/bundle-without-versioning/META-INF/MANIFEST.MF:Nar-Dependency-Id:
nifi-hadoop-libraries-nar
```
> Create a plugin system for Metron based on 'NAR'
> ------------------------------------------------
>
> Key: METRON-777
> URL: https://issues.apache.org/jira/browse/METRON-777
> Project: Metron
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> The success of the Metron project will be greatly dependent on community
> participation, and with that the ability to adapt and extend Metron without
> having to maintain a fork of the project.
> As organizations and individuals look to extend the Metron system with custom
> parsers, enrichments, and stellar functions that may be proprietary in
> nature, the ability to develop and deploy these extensions outside the Metron
> code base is critically important.
> To that end, and after community discussion and proposal we create or
> formalize the 'plugin' development story in Metron.
> The proposal is to adapt the Apache Nifi NAR system for use in Metron. This
> will provide the system with:
> * archetype(s) for developer projects and independent development
> * defined packaging and metadata for 'plugin' products
> * loading and instantiation with classloader isolation capabilities
> * removing the necessity for shading plugin jars
> These capabilities will also enable other features, such as plugin lifecycle,
> plugin configuration+redeployment, and other things.
> The plugin archetypes and their installation will be a followon
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
