[ 
https://issues.apache.org/jira/browse/METRON-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110968#comment-16110968
 ] 

ASF GitHub Bot commented on METRON-1038:
----------------------------------------

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/650#discussion_r130886124
  
    --- Diff: metron-stellar/stellar-common/README.md ---
    @@ -101,58 +101,69 @@ In the core language functions, we support basic 
functional programming primitiv
     
     ## Stellar Core Functions
     
    -|                                                                          
                          |
    -| ----------                                                               
                          |
    -| [ `ABS`](../../metron-analytics/metron-statistics#abs)                   
                          |
    -| [ `APPEND_IF_MISSING`](#append_if_missing)                               
                          |
    -| [ `BIN`](../../metron-analytics/metron-statistics#bin)                   
                          |
    -| [ `BLOOM_ADD`](#bloom_add)                                               
                          |
    -| [ `BLOOM_EXISTS`](#bloom_exists)                                         
                          |
    -| [ `BLOOM_INIT`](#bloom_init)                                             
                          |
    -| [ `BLOOM_MERGE`](#bloom_merge)                                           
                          |
    -| [ `CHOP`](#chop)                                                         
                          |
    -| [ `CHOMP`](#chomp)                                                       
                          |
    -| [ `COUNT_MATCHES`](#count_matches)                                       
                          |
    -| [ `DAY_OF_MONTH`](#day_of_month)                                         
                          |
    -| [ `DAY_OF_WEEK`](#day_of_week)                                           
                          |
    -| [ `DAY_OF_YEAR`](#day_of_year)                                           
                          |
    -| [ `DECODE`](#decode)                                                     
                          |
    -| [ `DOMAIN_REMOVE_SUBDOMAINS`](#domain_remove_subdomains)                 
                          |
    -| [ `DOMAIN_REMOVE_TLD`](#domain_remove_tld)                               
                          |
    -| [ `DOMAIN_TO_TLD`](#domain_to_tld)                                       
                          |
    -| [ `ENCODE`](#encode)                                                     
                          |
    -| [ `ENDS_WITH`](#ends_with)                                               
                          |
    -| [ `ENRICHMENT_EXISTS`](#enrichment_exists)                               
                          |
    -| [ `ENRICHMENT_GET`](#enrichment_get)                                     
                          |
    -| [ `FILL_LEFT`](#fill_left)                                               
                          |
    -| [ `FILL_RIGHT`](#fill_right)                                             
                          |
    -| [ `FILTER`](#filter)                                                     
                          |
    -| [ `FORMAT`](#format)                                                     
                          |
    -| [ 
`HLLP_CARDINALITY`](../../metron-analytics/metron-statistics#hllp_cardinality)  
                 |
    -| [ `HLLP_INIT`](../../metron-analytics/metron-statistics#hllp_init)       
                          |
    -| [ `HLLP_MERGE`](../../metron-analytics/metron-statistics#hllp_merge)     
                          |
    -| [ `HLLP_OFFER`](../../metron-analytics/metron-statistics#hllp_offer)     
                          |
    -| [ `GEO_GET`](#geo_get)                                                   
                          |
    -| [ `GET`](#get)                                                           
                          |
    -| [ `GET_FIRST`](#get_first)                                               
                          |
    -| [ `GET_LAST`](#get_last)                                                 
                          |
    -| [ `GET_SUPPORTED_ENCODINGS`](#get_supported_encodings)                   
                        |
    -| [ `IN_SUBNET`](#in_subnet)                                               
                          |
    -| [ `IS_DATE`](#is_date)                                                   
                          |
    -| [ `IS_ENCODING`](#is_encoding)                                           
                          |
    -| [ `IS_DOMAIN`](#is_domain)                                               
                          |
    -| [ `IS_EMAIL`](#is_email)                                                 
                          |
    -| [ `IS_EMPTY`](#is_empty)                                                 
                          |
    -| [ `IS_INTEGER`](#is_integer)                                             
                          |
    -| [ `IS_IP`](#is_ip)                                                       
                          |
    -| [ `IS_URL`](#is_url)                                                     
                          |
    -| [ `JOIN`](#join)                                                         
                          |
    -| [ `KAFKA_GET`](#kafka_get)                                               
                          |
    -| [ `KAFKA_PROPS`](#kafka_props)                                           
                          |
    -| [ `KAFKA_PUT`](#kafka_put)                                               
                          |
    -| [ `KAFKA_TAIL`](#kafka_tail)                                             
                          |
    -| [ `LENGTH`](#length)                                                     
                          |
    +|                                                                          
        |
    +| ----------                                                               
        |
    +| [ `ABS`](../../metron-analytics/metron-statistics#abs)                   
        |
    +| [ `APPEND_IF_MISSING`](#append_if_missing)                               
        |
    +| [ `BIN`](../../metron-analytics/metron-statistics#bin)                   
        |
    +| [ `BLOOM_ADD`](#bloom_add)                                               
        |
    +| [ `BLOOM_EXISTS`](#bloom_exists)                                         
        |
    +| [ `BLOOM_INIT`](#bloom_init)                                             
        |
    +| [ `BLOOM_MERGE`](#bloom_merge)                                           
        |
    +| [ `CEILING`](#ceiling)                                                   
        |
    +| [ `COS`](#cos)                                                           
        |
    +| [ `CHOP`](#chop)                                                         
        |
    +| [ `CHOMP`](#chomp)                                                       
        |
    +| [ `COUNT_MATCHES`](#count_matches)                                       
        |
    +| [ `DAY_OF_MONTH`](#day_of_month)                                         
        |
    +| [ `DAY_OF_WEEK`](#day_of_week)                                           
        |
    +| [ `DAY_OF_YEAR`](#day_of_year)                                           
        |
    +| [ `DECODE`](#decode)                                                     
        |
    +| [ `DOMAIN_REMOVE_SUBDOMAINS`](#domain_remove_subdomains)                 
        |
    +| [ `DOMAIN_REMOVE_TLD`](#domain_remove_tld)                               
        |
    +| [ `DOMAIN_TO_TLD`](#domain_to_tld)                                       
        |
    +| [ `ENCODE`](#encode)                                                     
        |
    +| [ `ENDS_WITH`](#ends_with)                                               
        |
    +| [ `ENRICHMENT_EXISTS`](#enrichment_exists)                               
        |
    +| [ `ENRICHMENT_GET`](#enrichment_get)                                     
        |
    +| [ `EXP`](#exp)                                                           
        |
    +| [ `FILL_LEFT`](#fill_left)                                               
        |
    +| [ `FILL_RIGHT`](#fill_right)                                             
        |
    +| [ `FILTER`](#filter)                                                     
        |
    +| [ `FLOOR`](#floor)                                                       
        |
    +| [ `FORMAT`](#format)                                                     
        |
    +| [ 
`HLLP_CARDINALITY`](../../metron-analytics/metron-statistics#hllp_cardinality) |
    +| [ `HLLP_INIT`](../../metron-analytics/metron-statistics#hllp_init)       
        |
    +| [ `HLLP_MERGE`](../../metron-analytics/metron-statistics#hllp_merge)     
        |
    +| [ `HLLP_OFFER`](../../metron-analytics/metron-statistics#hllp_offer)     
        |
    +| [ `GEO_GET`](#geo_get)                                                   
        |
    +| [ `GET`](#get)                                                           
        |
    +| [ `GET_FIRST`](#get_first)                                               
        |
    +| [ `GET_LAST`](#get_last)                                                 
        |
    +| [ `GET_SUPPORTED_ENCODINGS`](#get_supported_encodings)                   
        |
    +| [ `IN_SUBNET`](#in_subnet)                                               
        |
    +| [ `IS_DATE`](#is_date)                                                   
        |
    +| [ `IS_ENCODING`](#is_encoding)                                           
        |
    +| [ `IS_DOMAIN`](#is_domain)                                               
        |
    +| [ `IS_EMAIL`](#is_email)                                                 
        |
    +| [ `IS_EMPTY`](#is_empty)                                                 
        |
    +| [ `IS_INTEGER`](#is_integer)                                             
        |
    +| [ `IS_IP`](#is_ip)                                                       
        |
    +| [ `IS_URL`](#is_url)                                                     
        |
    +| [ `JOIN`](#join)                                                         
        |
    +| [ `KAFKA_GET`](#kafka_get)                                               
        |
    +| [ `KAFKA_PROPS`](#kafka_props)                                           
        |
    +| [ `KAFKA_PUT`](#kafka_put)                                               
        |
    +| [ `KAFKA_TAIL`](#kafka_tail)                                             
        |
    +| [ `LENGTH`](#length)                                                     
        |
    +<<<<<<< HEAD
    --- End diff --
    
    yep, fixed.  Good eye :)


> Stellar should have a better collection of basic math operations
> ----------------------------------------------------------------
>
>                 Key: METRON-1038
>                 URL: https://issues.apache.org/jira/browse/METRON-1038
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>
> At the moment the math functions are woefully incomplete.  
> We should add at least the ones difficult or impossible to reconstruct using 
> existing stellar primitives/math functions:
> * log10
> * log2
> * ln
> * sqrt
> * ceil
> * floor
> * sin
> * cos
> * tan



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to