[
https://issues.apache.org/jira/browse/METRON-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112789#comment-16112789
]
ASF GitHub Bot commented on METRON-379:
---------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/675#discussion_r131151842
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/LambdaExpression.java
---
@@ -56,9 +57,9 @@ public Object apply(List<Object> variableArgs) {
lambdaVariables.put(variables.get(i), null);
}
- VariableResolver variableResolver = variable ->
lambdaVariables.getOrDefault(variable
+ VariableResolver variableResolver = new
DefaultVariableResolver(variable -> lambdaVariables.getOrDefault(variable
--- End diff --
The only impact would be in the tests right now. Since we use the
MapResolver in most places ( shell, profiler, enrichments, parser ).
> Stellar - No Error When Adding Variables That Do Not Exist
> ----------------------------------------------------------
>
> Key: METRON-379
> URL: https://issues.apache.org/jira/browse/METRON-379
> Project: Metron
> Issue Type: Bug
> Affects Versions: 0.2.1BETA
> Reporter: Nick Allen
> Assignee: Otto Fowler
> Labels: stellar
>
> Running a Stellar expression like "1 + var + does + not + exist" results in a
> value of 1.0. I would expect an exception or error condition.
> {code:title=StellarTest.java|borderStyle=solid}
> @Test(expected = ParseException.class)
> public void testMissingVariables() {
> String query = "1 + cannot + add + missing + variables";
> run(query, new HashMap<>());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
