[
https://issues.apache.org/jira/browse/METRON-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113132#comment-16113132
]
ASF GitHub Bot commented on METRON-1079:
----------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/681
METRON-1079 Add NaN as a keyword in STELLAR language
Add "NaN" to STELLAR as a keyword.
Add NaN, and tests to verify that it works in line with the java
specification.
## Testing
Build and Tests should work.
Execute statement similar to the added tests in Stellar Shell.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/metron stellar_nan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/681.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #681
----
commit 827566937bfb9527abcd6979d1bb503c78db5f16
Author: Otto Fowler <ottobackwa...@gmail.com>
Date: 2017-08-03T16:06:00Z
Add NaN as a keyword in STELLAR language
----
> STELLAR NaN should be a keyword
> -------------------------------
>
> Key: METRON-1079
> URL: https://issues.apache.org/jira/browse/METRON-1079
> Project: Metron
> Issue Type: Bug
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> Right now, NaN is not a keyword, and it's use in stellar expressions is
> probably not being evaluated as NaN but as NULL.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
