[
https://issues.apache.org/jira/browse/METRON-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120526#comment-16120526
]
ASF GitHub Bot commented on METRON-777:
---------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/530#discussion_r132284538
--- Diff:
bundles-lib/src/main/java/org/apache/metron/bundles/bundle/BundleDetails.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.bundles.bundle;
+
+import org.apache.commons.vfs2.FileObject;
+
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+
+/**
+ * Metadata about a bundle.
+ * the withCoordinates and withBundleFile properties are required
+ */
+public class BundleDetails {
+
+ private final FileObject bundleFile;
+
+ private final BundleCoordinates coordinates;
+ private final BundleCoordinates dependencyCoordinates;
+
+ private final String buildTag;
+ private final String buildRevision;
+ private final String buildBranch;
+ private final String buildTimestamp;
+ private final String buildJdk;
+ private final String builtBy;
+
+ private BundleDetails(final Builder builder) {
+ this.bundleFile = builder.bundleFile;
+ this.coordinates = builder.coordinates;
+ this.dependencyCoordinates = builder.dependencyCoordinates;
+
+ this.buildTag = builder.buildTag;
+ this.buildRevision = builder.buildRevision;
+ this.buildBranch = builder.buildBranch;
+ this.buildTimestamp = builder.buildTimestamp;
+ this.buildJdk = builder.buildJdk;
+ this.builtBy = builder.builtBy;
+
+ if (this.coordinates == null) {
+ if (this.bundleFile == null) {
+ throw new IllegalStateException("Coordinate cannot be
null");
+ } else {
+ throw new IllegalStateException("Coordinate cannot be null
for " + this.bundleFile.getName());
+ }
+ }
+
+ if (this.bundleFile == null) {
+ throw new IllegalStateException("bundleFile cannot be null for
" + this.coordinates
+ .getId());
+ }
+ }
+
+ public FileObject getBundleFile() {
+ return bundleFile;
+ }
+
+ public BundleCoordinates getCoordinates() {
+ return coordinates;
+ }
+
+ public BundleCoordinates getDependencyCoordinates() {
+ return dependencyCoordinates;
+ }
+
+ public String getBuildTag() {
+ return buildTag;
+ }
+
+ public String getBuildRevision() {
+ return buildRevision;
+ }
+
+ public String getBuildBranch() {
+ return buildBranch;
+ }
+
+ public String getBuildTimestamp() {
+ return buildTimestamp;
+ }
+
+ public String getBuildJdk() {
+ return buildJdk;
+ }
+
+ public String getBuiltBy() {
+ return builtBy;
+ }
+
+ @Override
+ public String toString() {
+ return coordinates.toString();
+ }
+
+ public Date getBuildTimestampDate() {
+ if (buildTimestamp != null && !buildTimestamp.isEmpty()) {
+ try {
+ SimpleDateFormat buildTimestampFormat = new
SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'");
+ Date buildTimestampDate =
buildTimestampFormat.parse(buildTimestamp);
+ return buildTimestampDate;
+ } catch (ParseException parseEx) {
+ return null;
+ }
+ } else {
+ return null;
+ }
+ }
+
+ /**
+ * Builder for BundleDetails.
--- End diff --
done.
I also did the validation you had mentioned. When I got in there it made
more sense than not. Sorry I didn't see it before
> Create a plugin system for Metron based on 'NAR'
> ------------------------------------------------
>
> Key: METRON-777
> URL: https://issues.apache.org/jira/browse/METRON-777
> Project: Metron
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> The success of the Metron project will be greatly dependent on community
> participation, and with that the ability to adapt and extend Metron without
> having to maintain a fork of the project.
> As organizations and individuals look to extend the Metron system with custom
> parsers, enrichments, and stellar functions that may be proprietary in
> nature, the ability to develop and deploy these extensions outside the Metron
> code base is critically important.
> To that end, and after community discussion and proposal we create or
> formalize the 'plugin' development story in Metron.
> The proposal is to adapt the Apache Nifi NAR system for use in Metron. This
> will provide the system with:
> * archetype(s) for developer projects and independent development
> * defined packaging and metadata for 'plugin' products
> * loading and instantiation with classloader isolation capabilities
> * removing the necessity for shading plugin jars
> These capabilities will also enable other features, such as plugin lifecycle,
> plugin configuration+redeployment, and other things.
> The plugin archetypes and their installation will be a followon
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
