[ 
https://issues.apache.org/jira/browse/METRON-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123581#comment-16123581
 ] 

ASF GitHub Bot commented on METRON-1104:
----------------------------------------

GitHub user iraghumitra opened a pull request:

    https://github.com/apache/metron/pull/691

    METRON-1104: Build Failure - Due to Bootstrap version change

    ## Contributor Comments
    Hardcoding the version of bootstrap version to  4.0.0-alpha.6
    
    Bootstrap's latest version (4beta) removed some of the css files that we 
are using. The package.json in metron-alerts is configured to pick the latest 
version of Bootstrap after '4-alpha-6' of bootstrap for building the UI and 
hence there is a build failure. 
    
    In this PR I am hard coding the bootstrap version to '4-alpha-6'. We can 
move to Bootstrap 4Beta if required after fixing the failures. Also i noticed 
that the build version in package.json file is mentioned as 0.4.0 I corrected 
it to 0.4.1
    
    After the fix the build should be passing and metron-alerts should be 
functional
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iraghumitra/incubator-metron METRON-1104

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #691
    
----
commit 10832a4b61385a1416e1606c739bc315b13e30a3
Author: iraghumitra <raghumitra....@gmail.com>
Date:   2017-08-11T16:20:09Z

    Hardcoding the version of bootstrap version to  4.0.0-alpha.6

----


> Build Failure - Due to Bootstrap version change
> -----------------------------------------------
>
>                 Key: METRON-1104
>                 URL: https://issues.apache.org/jira/browse/METRON-1104
>             Project: Metron
>          Issue Type: Bug
>            Reporter: RaghuMitra
>            Assignee: RaghuMitra
>
> Build  failure is seen as bootstrap moved to 4-beta from v4.0.0-alpha.6
> [INFO] ERROR in multi script-loader!./~/jquery/dist/jquery.js
> script-loader!./~/tether/dist/js/tether.js
> script-loader!./~/ace-builds/src-noconflict/ace.js
> [INFO] Module not found: Error: Can't resolve
> '/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/jquery/dist/jquery.js'
> in
> '/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/@angular/cli/models/webpack-configs'
> [INFO]  @ multi script-loader!./~/jquery/dist/jquery.js
> script-loader!./~/tether/dist/js/tether.js
> script-loader!./~/ace-builds/src-noconflict/ace.js
> [INFO]
> [INFO] ERROR in multi script-loader!./~/jquery/dist/jquery.js
> script-loader!./~/tether/dist/js/tether.js
> script-loader!./~/ace-builds/src-noconflict/ace.js
> [INFO] Module not found: Error: Can't resolve
> '/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/tether/dist/js/tether.js'
> in
> '/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/@angular/cli/models/webpack-configs'
> [INFO]  @ multi script-loader!./~/jquery/dist/jquery.js
> script-loader!./~/tether/dist/js/tether.js
> script-loader!./~/ace-builds/src-noconflict/ace.js
> [INFO]
> [INFO] ERROR in ./src/vendor.scss
> [INFO] Module build failed:
> [INFO] @import "~bootstrap/scss/normalize";
> [INFO] ^
> [INFO]       File to import not found or unreadable:
> ~bootstrap/scss/normalize.
> [INFO] Parent style sheet: stdin
> [INFO]       in
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> (line 31, column 1)
> [INFO]  @ multi ./~/font-awesome/css/font-awesome.css ./src/vendor.scss
> ./src/styles.scss
> [INFO]
> [INFO] ERROR in ./src/styles.scss
> [INFO] Module build failed:
> [INFO] @import "~bootstrap/scss/normalize";
> [INFO] ^
> [INFO]       File to import not found or unreadable:
> ~bootstrap/scss/normalize.
> [INFO] Parent style sheet:
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> [INFO]       in
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> (line 31, column 1)
> [INFO]  @ multi ./~/font-awesome/css/font-awesome.css ./src/vendor.scss
> ./src/styles.scss
> [INFO]
> [INFO] ERROR in Child compilation failed:
> [INFO] Module build failed:
> [INFO] @import "~bootstrap/scss/normalize";
> [INFO] ^
> [INFO]       File to import not found or unreadable:
> ~bootstrap/scss/normalize.
> [INFO] Parent style sheet:
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> [INFO]       in
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> (line 31, column 1):
> [INFO] Error:
> [INFO] @import "~bootstrap/scss/normalize";
> [INFO] ^
> [INFO]       File to import not found or unreadable:
> ~bootstrap/scss/normalize.
> [INFO] Parent style sheet:
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> [INFO]       in
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> (line 31, column 1)
> [INFO]
> [INFO] ERROR in ./src/main.ts
> [INFO] Module not found: Error: Can't resolve
> './$$_gendir/app/app.module.ngfactory' in
> '/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src'
> [INFO]  @ ./src/main.ts 20:0-74
> [INFO]  @ multi ./src/main.ts
> [INFO]
> [INFO] ERROR in ./src/styles.scss
> [INFO] Module build failed: ModuleBuildError: Module build failed:
> [INFO] @import "~bootstrap/scss/normalize";
> [INFO] ^
> [INFO]       File to import not found or unreadable:
> ~bootstrap/scss/normalize.
> [INFO] Parent style sheet:
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> [INFO]       in
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> (line 31, column 1)
> [INFO]     at runLoaders
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/webpack/lib/NormalModule.js:192:19)
> [INFO]     at
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/loader-runner/lib/LoaderRunner.js:364:11
> [INFO]     at
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/loader-runner/lib/LoaderRunner.js:230:18
> [INFO]     at context.callback
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
> [INFO]     at Object.asyncSassJobQueue.push [as callback]
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/sass-loader/lib/loader.js:55:13)
> [INFO]     at Object.<anonymous>
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/async/dist/async.js:2244:31)
> [INFO]     at Object.callback
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/async/dist/async.js:906:16)
> [INFO]     at options.error
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/node-sass/lib/index.js:294:32)
> [INFO]
> [INFO] ERROR in ./src/vendor.scss
> [INFO] Module build failed: ModuleBuildError: Module build failed:
> [INFO] @import "~bootstrap/scss/normalize";
> [INFO] ^
> [INFO]       File to import not found or unreadable:
> ~bootstrap/scss/normalize.
> [INFO] Parent style sheet: stdin
> [INFO]       in
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/src/vendor.scss
> (line 31, column 1)
> [INFO]     at runLoaders
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/webpack/lib/NormalModule.js:192:19)
> [INFO]     at
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/loader-runner/lib/LoaderRunner.js:364:11
> [INFO]     at
> /Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/loader-runner/lib/LoaderRunner.js:230:18
> [INFO]     at context.callback
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
> [INFO]     at Object.asyncSassJobQueue.push [as callback]
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/sass-loader/lib/loader.js:55:13)
> [INFO]     at Object.<anonymous>
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/async/dist/async.js:2244:31)
> [INFO]     at Object.callback
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/async/dist/async.js:906:16)
> [INFO]     at options.error
> (/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node_modules/node-sass/lib/index.js:294:32)
> [ERROR] npm ERR! Darwin 15.5.0
> [ERROR] npm ERR! argv
> "/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node/node"
> "/Users/cstella/Documents/workspace/metron/fork/incubator-metron/metron-interface/metron-alerts/node/node_modules/npm/bin/npm-cli.js"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to