[jira] [Commented] (METRON-1107) DAY_OF_{YEAR,MONTH} stellar functions return incorrect results with epoch seconds

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/METRON-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124795#comment-16124795
 ] 

ASF GitHub Bot commented on METRON-1107:
----------------------------------------

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/metron/pull/692

    METRON-1107 add support for handling epoch dates in seconds or milliseconds

    This PR adds the capability for the Stellar Date functions which take Long 
times to handle both seconds and milliseconds, so they just handle epoch time.
    
    ## Testing
    run stellar shell and exercise the Stellar date functions using 
[epochconverter.com](https://www.epochconverter.com).
    
    <img width="742" alt="screen shot 2017-08-13 at 00 32 06" 
src="https://user-images.githubusercontent.com/1111551/29246163-f7b4b882-7fbe-11e7-9fb7-43892f73eca8.png";>
    
    Use both the epoch seconds and millisecond values
    
    
    
    
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/metron stellar_time_seconds

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/692.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #692
    
----
commit c26b3d807893256d79b0cd786ac82a708ec14498
Author: Otto Fowler <ottobackwa...@gmail.com>
Date:   2017-08-13T04:28:05Z

    add support for handling dates in seconds or milliseconds

----


> DAY_OF_{YEAR,MONTH} stellar functions return incorrect results with epoch 
> seconds
> ---------------------------------------------------------------------------------
>
>                 Key: METRON-1107
>                 URL: https://issues.apache.org/jira/browse/METRON-1107
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Jon Zeolla
>            Assignee: Otto Fowler
>
> While testing METRON-1091 I found an issue where the DAY_OF_YEAR was 
> improperly returning the same as DAY_OF_MONTH, but the DAY_OF_MONTH was also 
> incorrect.
> [Stellar]>>> DAY_OF_YEAR(1483239091)
> 17
> [Stellar]>>> DAY_OF_MONTH(1483239091)
> 17
> [Stellar]>>> DAY_OF_MONTH(1502592893)
> 18
> [Stellar]>>> DAY_OF_YEAR(1502592893)
> 18



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)