[
https://issues.apache.org/jira/browse/METRON-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134845#comment-16134845
]
ASF GitHub Bot commented on METRON-1077:
----------------------------------------
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r134166875
--- Diff: metron-interface/metron-alerts/src/app/service/rest-api-impl.ts
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import {Observable} from 'rxjs/Rx';
+import {Headers, RequestOptions} from '@angular/http';
+
+import {HttpUtil} from '../utils/httpUtil';
+import {AlertsSearchResponse} from '../model/alerts-search-response';
+import {SearchRequest} from '../model/search-request';
+import {ElasticSearchLocalstorageImpl} from
'./elasticsearch-localstorage-impl';
+import {INDEXES} from '../utils/constants';
+import {ColumnMetadata} from '../model/column-metadata';
+import {MetronRestApiUtils} from '../utils/metron-rest-api-utils';
+import {AlertSource} from '../model/alert-source';
+
+export class RestApiImpl extends ElasticSearchLocalstorageImpl {
--- End diff --
@merrimanr the abstraction was created to facilitate rest-api creation. I
am also a fan of having http calls in services. But should we remove the
abstraction once all the rest-api's are implemented. This way we will have a
clear visibility into the api's that are available and api's that needs to be
worked on.
Please feel free to suggest. The code change would be small either ways :)
> Use column meta data end point in alerts ui
> -------------------------------------------
>
> Key: METRON-1077
> URL: https://issues.apache.org/jira/browse/METRON-1077
> Project: Metron
> Issue Type: Improvement
> Reporter: RaghuMitra
> Assignee: RaghuMitra
>
> Use the api in https://github.com/apache/metron/pull/662 PR instead of
> getting the fields from ES directly
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
