[
https://issues.apache.org/jira/browse/METRON-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138380#comment-16138380
]
ASF GitHub Bot commented on METRON-1121:
----------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/707#discussion_r134758959
--- Diff:
metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/DefaultProfileBuilder.java
---
@@ -253,7 +265,8 @@ private void assign(Map<String, String> expressions,
Map<String, Object> transie
.forEach((expr) -> results.add(executor.execute(expr,
transientState, Object.class)));
} catch (Throwable e) {
- String msg = format("Bad '%s' expression: %s, profile=%s,
entity=%s", expressionType, e.getMessage(), profileName, entity);
+ String msg = format("Bad '%s' expression: error=%s, profile=%s,
entity=%s", expressionType, e.getMessage(), profileName, entity);
+ LOG.error(msg);
--- End diff --
Can you pass `e` as the second argument to `LOG.error`?
> Ignore Profile with Bad 'init', 'update' or 'groupBy'
> -----------------------------------------------------
>
> Key: METRON-1121
> URL: https://issues.apache.org/jira/browse/METRON-1121
> Project: Metron
> Issue Type: Bug
> Reporter: Nick Allen
> Assignee: Nick Allen
> Fix For: 0.4.1
>
>
> The Profiler needs to gracefully ignore profiles that have a bad 'init',
> 'update' or 'groupBy' expression. Under certain conditions a message may not
> be applied to all valid profiles, due to a single bad profile.
> If the Profiler is running with multiple profiles defined and one of those
> profiles has a Stellar expression that throws an exception for either the
> 'init', 'update' or 'groupBy', the current logic will not continue to attempt
> to apply the message to the remaining valid profiles. Only valid profiles
> executed before the bad profile will have the message applied. Any valid
> profiles after the bad profile will not see the message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
