[ 
https://issues.apache.org/jira/browse/METRON-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159421#comment-16159421
 ] 

Matt Foley edited comment on METRON-1163 at 9/8/17 9:50 PM:
------------------------------------------------------------

The attached patch file causes apache-rat-plugin to ignore the two offending 
files.
The reason given for the .bundle.css file is appropriate.

I am not comfortable with ignoring the empty "3rdpartylicenses.txt" file.  If 
it becomes non-empty in the future, we are likely to miss it.  If anyone can 
think of a better solution, or a way to prevent the file from being created, 
please share it.


was (Author: mattf):
This patch file causes apache-rat-plugin to ignore the two offending files.
The reason given for the .bundle.css file is appropriate.

I am not comfortable with ignoring the empty "3rdpartylicenses.txt" file.  If 
it becomes non-empty in the future, we are likely to miss it.  If anyone can 
think of a better solution, or a way to prevent the file from being created, 
please share it.

> RAT failures for metron-interface/metron-alerts
> -----------------------------------------------
>
>                 Key: METRON-1163
>                 URL: https://issues.apache.org/jira/browse/METRON-1163
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.4.1
>            Reporter: Matt Foley
>            Assignee: Matt Foley
>         Attachments: METRON-1163.patch
>
>
> When the maven-rat-plugin runs against metron-alerts component, it has:
> bq. [ERROR] Failed to execute goal 
> org.apache.rat:apache-rat-plugin:0.12:check (default) on project 
> metron-alerts: Too many files with unapproved license: 2 See RAT report in: 
> .../metron-interface/metron-alerts/target/rat.txt
> In the report file it says:
> Files with unapproved licenses:
> *  .../metron-interface/metron-alerts/dist/3rdpartylicenses.txt
> *  
> .../metron-interface/metron-alerts/dist/styles.a0b6b99c10d9a13dc67e.bundle.css
> The file "3rdpartylicenses.txt" is an empty (0-length) file.  Should it be?
> The styles.a0b6b99c10d9a13dc67e.bundle.css file is a complex file referencing
>  *  Font Awesome 4.7.0 by @davegandy - http://fontawesome.io - @fontawesome
>  *  License - http://fontawesome.io/license (Font: SIL OFL 1.1, CSS: MIT 
> License)
> which in turn says:
> * all CSS files License: MIT License (Apache Category A)
> * Font License: SIL OFL 1.1 (Apache Category B)
> * Documentation License: CC BY 3.0 (Apache Category B)
> Both of these files are downloaded (or generated?) during build (they're not 
> in the Metron repository), but we're still responsible for the licensing.  
> Suggestions for passing RAT test?  If the suggestion is to exclude these 
> files, please provide justification.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to