[
https://issues.apache.org/jira/browse/METRON-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189733#comment-16189733
]
ASF GitHub Bot commented on METRON-1161:
----------------------------------------
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/737
Wait, I'm confused, the current behavior is to default to the storm config.
Why did you pull that into the SensorParserConfig?
The issue with what you've done here is that when you save out the configs
into zookeeper, you are serializing the object with the values set (including
those defaults). Now, if someone restarts the topology, those are the values
set regardless of what is set in the storm config.
Can we please just solve this by some hover-over text indicating if the
field is not set, then the storm defaults are used? Maybe even indicating what
the default currently is. I'd have honestly made those values Optional if I
could've (serialization issues caused that not to be the case).
I guess what I'm saying is that, no, I don't like this approach. :)
> Add ability to edit parser command line options in the management UI
> --------------------------------------------------------------------
>
> Key: METRON-1161
> URL: https://issues.apache.org/jira/browse/METRON-1161
> Project: Metron
> Issue Type: New Feature
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> This is a follow on to https://issues.apache.org/jira/browse/METRON-1134 that
> exposes the new zookeeper parser command line options in the Management UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
