[
https://issues.apache.org/jira/browse/METRON-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196969#comment-16196969
]
ASF GitHub Bot commented on METRON-1223:
----------------------------------------
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/788#discussion_r143470175
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alert-details/alert-details.component.ts
---
@@ -133,6 +173,40 @@ export class AlertDetailsComponent implements OnInit {
});
}
+ onAddComment() {
+ let alertComment = new AlertComment(this.alertCommentStr,
this.authenticationService.getCurrentUserName(), new Date().getTime());
+ let tAlertComments = this.alertCommentsWrapper.map(alertsWrapper =>
alertsWrapper.alertComment);
+ tAlertComments.unshift(alertComment);
+ this.patchAlert(new Patch('add', '/comments', tAlertComments));
+ }
+
+ patchAlert(patch: Patch) {
+ let patchRequest = new PatchRequest();
+ patchRequest.guid = this.alertSource.guid;
+ patchRequest.index = this.alertIndex;
+ patchRequest.patch = [patch];
+ patchRequest.sensorType = this.alertSourceType;
+
+ this.updateService.patch(patchRequest).subscribe(() => {
+ this.getData();
+ });
+ }
+
+ onDeleteComment(index: number) {
+ let commentText = 'Do you wish to delete the comment ';
+ if (this.alertCommentsWrapper[index].alertComment.comment.length > 25
) {
+ commentText += ' \'' +
this.alertCommentsWrapper[index].alertComment.comment.substr(0, 25) + '...\'';
+ } else {
+ commentText += ' \'' +
this.alertCommentsWrapper[index].alertComment.comment + '\'';
+ }
+
+
this.metronDialogBox.showConfirmationMessage(commentText).subscribe(response =>
{
+ if (response) {
+ this.alertCommentsWrapper.splice(index, 1);
+ this.patchAlert(new Patch('add', '/comments',
this.alertCommentsWrapper.map(alertsWrapper => alertsWrapper.alertComment)));
--- End diff --
@justinleet makes sense, the goal is to get something in fast and iterate,
but it sounds like getting the field nested is not going to be much more work
than the alerts work we already have to do, so can piggyback on that and
minimise the upgrade effort. There is I believe some separate work going on
making reindexing easier, which may help here (though we should also ensure
that that work is DAO aware when reindexing commented stuff from HDFS)
> Add support to add comments for alerts
> --------------------------------------
>
> Key: METRON-1223
> URL: https://issues.apache.org/jira/browse/METRON-1223
> Project: Metron
> Issue Type: New Feature
> Reporter: RaghuMitra
> Assignee: RaghuMitra
>
> Add support for adding arbitrary text notes to an alert. This can be achieved
> by using METRON-1051.
> The comments should contain the username of the user who created the comment
> and timestamp when the comment was added.
> Users should be able to remove a comment too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
