[ 
https://issues.apache.org/jira/browse/METRON-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197428#comment-16197428
 ] 

ASF GitHub Bot commented on METRON-1232:
----------------------------------------

Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/787#discussion_r143541485
  
    --- Diff: metron-interface/metron-alerts/e2e/alerts-list/alerts-list.po.ts 
---
    @@ -231,10 +231,12 @@ export class MetronAlertsPage {
       }
     
       clickRemoveSearchChip() {
    -    let aceLine = element.all(by.css('.ace_keyword')).get(0);
    -    browser.actions().mouseMove(aceLine).perform().then(() => {
    -      this.waitForElementPresence(element(by.css('.ace_value i'))).then(() 
=> {
    -        element.all(by.css('.ace_value i')).get(0).click();
    +    element(by.css('app-alerts-list 
.ace_text-input')).sendKeys('').then(() => {
    --- End diff --
    
    I'd like to see a couple things with this. Can you add some code comments 
along with perhaps splitting this up into more descriptive functions? There's a 
lot of chaining/lambda/closures going on here.


> Alert status changes are not reflected in list view
> ---------------------------------------------------
>
>                 Key: METRON-1232
>                 URL: https://issues.apache.org/jira/browse/METRON-1232
>             Project: Metron
>          Issue Type: Bug
>            Reporter: RaghuMitra
>            Assignee: RaghuMitra
>
> When escalating an alert (changing its status), the list view does not 
> reflect the change until a refresh occurs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to