[
https://issues.apache.org/jira/browse/METRON-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208120#comment-16208120
]
ASF GitHub Bot commented on METRON-1255:
----------------------------------------
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/802
METRON-1255: MetaAlert search is not filtering on status
## Contributor Comments
This PR primarily fixes filtering on metaalert status but also includes a
couple other minor fixes as well. The nested query was moved to accompany a
normal query string query (both are now 'should' clauses under a boolQuery) so
that a filter will match on either a top level alert field and a nested alert
field in a metaalert. There was also a regression introduced in
https://github.com/apache/metron/pull/793 that causes a search with the index
set to "metaalert" to not match because '_index* is now appended instead of
just '*'. This PR fixes that by changing the "metaalert" index to
"metaalert_index" and adds a test case to catch it in the future.
This has been validated by running the unit/integration tests and in full
dev. To test in full dev, create a couple metaalerts with the
http://node1:8082/swagger-ui.html#!/meta-alert-controller/createUsingPOST
endpoint:
```
{
"groups": [
"string"
],
"guidToIndices": {"4c732cb0-05cc-bdb4-9898-886a93129aba":"index_name"}
}
```
```
{
"groups": [
"string"
],
"guidToIndices": {"c4c5e418-3938-099e-bb0d-37028a98dca8":"index_name"}
}
```
A search on metaalerts with the
http://node1:8082/swagger-ui.html#!/search-controller/searchUsingPOST endpoint:
```
{
"from": 0,
"indices": [
"metaalert"
],
"query": "*",
"size": 5
}
```
should return both metaalerts:
```
{
"total": 2,
"results": [
...
]
}
```
Then patch one of them to set the status to 'inactive':
```
{
"guid": "fea984ad-63d3-4c8c-9bf4-aa9da11eea2b",
"index": "metaalert_index",
"patch": [{
"op":"add",
"path":"/status",
"value":"inactive"
}],
"sensorType": "metaalert"
}
```
Now a search should only return the active metaalert:
```
{
"total": 1,
"results": [
...
]
}
```
Filtering metaalerts by child alert fields should also work correctly:
```
{
"from": 0,
"indices": [
"metaalert"
],
"query": "alert.ip_dst_addr:62.75.195.236 AND alert.host:62.75.195.236",
"size": 5
}
```
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1255
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/802.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #802
----
commit 28bb5c13199a483d9c8c51bb782293050a429fe9
Author: merrimanr <[email protected]>
Date: 2017-10-17T16:15:24Z
initial commit
commit 3aa4c158c11c1a72e2e80a9fa2e98a6f1be57348
Author: merrimanr <[email protected]>
Date: 2017-10-17T16:16:07Z
Merge remote-tracking branch 'mirror/master' into METRON-1255
commit bc923540e3a33225d458db9505045cf062d553f2
Author: merrimanr <[email protected]>
Date: 2017-10-17T18:02:49Z
resolved merge conflicts
----
> MetaAlert search is not filtering on status
> -------------------------------------------
>
> Key: METRON-1255
> URL: https://issues.apache.org/jira/browse/METRON-1255
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
>
> Currently both active and inactive metaAlerts are being returned in a search.
> Only active metaAlerts should be returned.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
