[
https://issues.apache.org/jira/browse/METRON-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208314#comment-16208314
]
ASF GitHub Bot commented on METRON-1260:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/804
METRON-1260 Include Alerts UI in Ambari Service Check
As part of #799, I improved the Ambari Service Check for Metron. I failed
to include any checks for the Alerts UI, that being a new addition to the
MPack. This PR adds the additional checks for the Alerts UI and also some
additional refactoring.
## Testing
I tested this by spinning up Full Dev and running the service check
manually. I tested both positive and negative side for the Alerts UI running.
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/804.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #804
----
commit 59684f16873b331f185c259b6e914c9a7e8f0328
Author: Nick Allen <[email protected]>
Date: 2017-10-17T18:43:42Z
METRON-1260 Include Alerts UI in Ambari Service Check
----
> Include Alerts UI in Ambari Service Check
> -----------------------------------------
>
> Key: METRON-1260
> URL: https://issues.apache.org/jira/browse/METRON-1260
> Project: Metron
> Issue Type: Bug
> Reporter: Nick Allen
> Assignee: Nick Allen
>
> The Alerts UI is not currently included in the Metron Service Check that is a
> part of the Ambari MPack. This should be added.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
