[ 
https://issues.apache.org/jira/browse/METRON-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215188#comment-16215188
 ] 

ASF GitHub Bot commented on METRON-1274:
----------------------------------------

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/813#discussion_r146276684
  
    --- Diff: 
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java
 ---
    @@ -187,9 +187,9 @@ public void test() throws Exception {
         sensorParserConfig.setSensorTopic("broTest");
         sensorParserConfigService.save(sensorParserConfig);
         {
    -      final Map<String, Object> expectedGlobalConfig = globalConfig;
    +      final SensorParserConfig expectedSensorParserConfig = 
sensorParserConfig;
           //we must wait for the config to find its way into the config.
    -      TestUtils.assertEventually(() -> 
Assert.assertEquals(expectedGlobalConfig, globalConfigService.get()));
    +      TestUtils.assertEventually(() -> 
Assert.assertEquals(expectedSensorParserConfig, 
sensorParserConfigService.findOne("broTest")));
    --- End diff --
    
    oh crap, that's not even a legit assertion.  I'm embarassed now ;)


> Master has failure in StormControllerIntegrationTest
> ----------------------------------------------------
>
>                 Key: METRON-1274
>                 URL: https://issues.apache.org/jira/browse/METRON-1274
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Justin Leet
>
> Potentially resulting from METRON-1241
> More details in log at https://travis-ci.org/apache/metron/builds/290640009
> Here's the super high level failure.
> {code}
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.107 sec <<< 
> FAILURE! - in org.apache.metron.rest.controller.StormControllerIntegrationTest
> test(org.apache.metron.rest.controller.StormControllerIntegrationTest)  Time 
> elapsed: 0.068 sec  <<< FAILURE!
> java.lang.AssertionError: JSON path "$.status" expected:<SUCCESS> but 
> was:<ERROR>
> {code}
> Seems possibly intermittent. 
> https://travis-ci.org/apache/metron/builds/290640009 failed, but 
> https://travis-ci.org/apache/metron/builds/291527599 (which should have that 
> code) succeeded.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to