[ 
https://issues.apache.org/jira/browse/METRON-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217852#comment-16217852
 ] 

ASF GitHub Bot commented on METRON-1272:
----------------------------------------

Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/811#discussion_r146715818
  
    --- Diff: 
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
 ---
    @@ -295,19 +341,199 @@ protected Document 
buildCreateDocument(MultiGetResponse multiGetResponse, List<S
       /**
        * Process an update to a meta alert itself.
        * @param update The update Document to be applied
    -   * @param index The optional index to update to
        * @throws IOException If there's a problem running the update
        */
    -  protected void handleMetaUpdate(Document update, Optional<String> index) 
throws IOException {
    -    // We have an update to a meta alert itself
    -    // If we've updated the alerts field (i.e add/remove), recalculate 
meta alert scores.
    +  protected void handleMetaUpdate(Document update) throws IOException {
    --- End diff --
    
    If I have a metaalert with a large number of alerts (say 525 in this 
example), then I attempt to add 1 or 2 alerts to that metaalert, the REST API 
responds back with a 500 error.  
    
    I don't see any error messages in the logs.  I assume that error is coming 
from somewhere in here.
    
    The UI itself never reports an error or acknowledges.  Of course that is a 
separate problem that we should fix in a separate PR.
    
    
    ![screen shot 2017-10-24 at 6 53 24 
pm](https://user-images.githubusercontent.com/2475409/31972179-5e89d79c-b8ed-11e7-9e7a-7ac6c0b718c8.png)
    
    But I do find that the metaalert was actually updated, as the number of 
alerts increased (from 527 to 529 here).
    
    ![screen shot 2017-10-24 at 6 59 04 
pm](https://user-images.githubusercontent.com/2475409/31972201-78e06b24-b8ed-11e7-80c5-4bb01a3e72b7.png)
      
    



> Hide child alerts from searches and grouping if they belong to meta alerts
> --------------------------------------------------------------------------
>
>                 Key: METRON-1272
>                 URL: https://issues.apache.org/jira/browse/METRON-1272
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>
> If an alert is already grouped into a meta alert, it's nice to route 
> everything through the same query structure and allow sorting alongside them, 
> etc.  However, showing alerts that are already contained in a meta alert is 
> potential clutter for a user and gives the impression an event has occurred 
> twice if it's in a standalone alert and a metaalert.
> This should hide alerts contained in a meta alert from searches (which will 
> always match the enclosing meta alert anyway, so nothing will be lost from 
> the search).
> They should also be hidden from grouping calls, because the user has already 
> manually grouped them during prior slicing and dicing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to