[
https://issues.apache.org/jira/browse/METRON-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222547#comment-16222547
]
ASF GitHub Bot commented on METRON-1212:
----------------------------------------
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/774
Thanks for looking at this again Nick, let me try to answer your questions.
TL;DR
--------
I'm sorry for my confusion with your original statement. I had in mind
this part of @mattf-horton 's email on these pull requests:
> The first PR will be just the “bundle” mechanism and the maven plugin.
> Both are adaptations from the Apache NiFi project, and have already been
> reviewed as part of PR# 530. Review is acknowledged to be purely
> theoretical, and testing is based on the junit tests and integration
> tests.
I thought an example project to look at would answer your question, not
that you actually wanted to do it, or have instructions to do it. Especial
since you didn't say "the readme should have better instructions for creating a
project that uses the plugin".
While creating bundles by hand is not in the initial use case, if you feel
it is important I'll write a readme.
---------
As with the NiFi version of the maven plugin, the 100% use case in practice
( and for initial dev in metron ) is to have bundles create as part of the
archetype project generation. When I 'adapted' the maven plugin, which
consisted of adding the ability to rename the extension of the product and
change the metadata prefixes, I did not make changes to the documentation of
the plugin beyond documenting my changes. I also did not attempt to add maven
test harness support for the plugin, as it was not present in the original
project. Thus, the create by hand scenario for our version is as lacking as
the create by hand scenario is in the origin nifi project. I tried to avoid
changing the plugin as much as possible, as it is already in use in NiFi.
As we had discussed in the threads and the meetings, this initial PR would
contain the plugin and the bundle, and the practical testing would be limited.
I created and added reference to the test project because it is a simple
example of a project that utilizes the plugin to create a bundle. I did this
as opposed to writing out a step by step guide to how to create a multi module
maven project, as I mistakenly thought this would be helpful given the context
of the review.
@mattf-horton, would it be possible for you to help us with a comment as to
your approach when you reviewed this functionality? It might help if you could
summarize your feelings as well. The context is different, as the review
within 777 could not be a +1 for the PR since this was only part of the total,
but since you are the only one to have had reviewed this, your views are pretty
important.
> Bundles and Maven Plugin
> ------------------------
>
> Key: METRON-1212
> URL: https://issues.apache.org/jira/browse/METRON-1212
> Project: Metron
> Issue Type: Sub-task
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> The first effort will be to land the bundle system and supporting maven
> plugin on master
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
