[ 
https://issues.apache.org/jira/browse/METRON-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235729#comment-16235729
 ] 

ASF GitHub Bot commented on METRON-1286:
----------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/823#discussion_r148532449
  
    --- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/OrdinalFunctions.java
 ---
    @@ -0,0 +1,75 @@
    +package org.apache.metron.stellar.dsl.functions;
    +
    +import org.apache.metron.stellar.dsl.BaseStellarFunction;
    +import org.apache.metron.stellar.dsl.Stellar;
    +
    +import java.util.Collections;
    +import java.util.List;
    +import java.util.stream.Collectors;
    +
    +public class OrdinalFunctions {
    +
    +    /**
    +     * Stellar Function: MAX
    +     * <p>
    +     * Return the maximum value of a list of input values in a Stellar list
    +     */
    --- End diff --
    
    It may be more clear to have MAX  | MIN  function for Numbers and a set of 
SORTED functions for Strings.


> Add MAX & MIN Stellar functions 
> --------------------------------
>
>                 Key: METRON-1286
>                 URL: https://issues.apache.org/jira/browse/METRON-1286
>             Project: Metron
>          Issue Type: Improvement
>    Affects Versions: 0.4.1
>            Reporter: Jasper Knulst
>            Priority: Minor
>              Labels: features
>             Fix For: 0.4.2
>
>
> Currently Stellar lacks straightforward MAX & MIN functions that take just a 
> list of values as input.
> The functions STATS_MAX and STATS_MIN only take the internal Stellar 
> statistics object as input.
> Having MAX and MIN will be easier and understandable to most



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to