Ryan Merriman created METRON-1315:
-------------------------------------
Summary: DAO implementations are tested in isolation and may
return inconsistent results
Key: METRON-1315
URL: https://issues.apache.org/jira/browse/METRON-1315
Project: Metron
Issue Type: Bug
Reporter: Ryan Merriman
Currently our DAOs are covered by integration tests but they are generally
tested by themselves outside of the MultiIndexDao interface. Because of this
different DAO implementations may return inconsistent results and lead to
runtime bugs that are difficult to track down.
Since they all conform to the same interface, I propose we have a single
collection of tests that are used to test all the DAO implementations.
Anything specific to that implementation, or not implemented in all DAOs,
should be kept in a separate test. For example, the IndexDao.search function
would be moved to a separate test since it is not implemented by the HBaseDao
and the meta alert functions would be in a separate test since
ElasticsearchMetaAlertDao extends the base ElasticsearchDao class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
