[ 
https://issues.apache.org/jira/browse/METRON-1294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255870#comment-16255870
 ] 

ASF GitHub Bot commented on METRON-1294:
----------------------------------------

Github user JonZeolla commented on the issue:

    https://github.com/apache/metron/pull/827
  
    I didn't get myself intimately familiar with this PR, but I wanted to 
mention that assuming two fields with the same name but different types between 
indexes are not the same may not always hold.  For instance, in bro there are a 
couple of field names that overlap between bro logs, and so the type in the bro 
index needs to be one that can commonly work (usually string), but if there was 
no overlap it would be a different type.  
[Example](https://github.com/JonZeolla/metron/blob/master/metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template#L131-L134).
  Not even positive this is relevant (especially given 
`getCommonColumnMetadata` may just get removed), but in case it is I wanted to 
mention it.


> IP addresses are not formatted correctly in facet and group results
> -------------------------------------------------------------------
>
>                 Key: METRON-1294
>                 URL: https://issues.apache.org/jira/browse/METRON-1294
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>
> Fields that are of type IP address are being returned in numerical format 
> whereas they should be returned in string format.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to