[ 
https://issues.apache.org/jira/browse/METRON-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262808#comment-16262808
 ] 

ASF GitHub Bot commented on METRON-1328:
----------------------------------------

Github user anandsubbu commented on the issue:

    https://github.com/apache/metron/pull/846
  
    Hi @ottobackwards , thanks for your review.
    
    I prefixed a 'WARNING' to the message text so it would catch the eye of the 
user. Also, I removed the else bit for docker running scenario, since this will 
fail for the case where docker is not installed at all. If I retain the else 
block, it would report saying 'Docker daemon is running'. 
    
    So, in summary here are the cases:
    
    1. Docker installed and running would print:
    ```bash
    Docker version 1.12.1, build 23cf638, experimental
    ```
    2. Docker installed, but not running would print:
    ```bash
    Docker version 1.12.1, build 23cf638, experimental
    WARNING: Docker daemon is not running
    ```
    3. Docker not installed would print:
    ```bash
    -bash: docker: command not found
    ```
    Let me know if this looks okay.


> Enhance platform-info.sh script to check if docker daemon is running 
> ---------------------------------------------------------------------
>
>                 Key: METRON-1328
>                 URL: https://issues.apache.org/jira/browse/METRON-1328
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Anand Subramanian
>            Assignee: Anand Subramanian
>
> For successful full-dev the docker daemon needs to be in running state. It is 
> possible at times that docker is installed, but is not started. It would be 
> good to add a check to the platform-info script to check for running status.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to