[
https://issues.apache.org/jira/browse/METRON-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280443#comment-16280443
]
ASF GitHub Bot commented on METRON-1344:
----------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r155288298
--- Diff: metron-interface/metron-alerts/e2e/utils/e2e_util.ts ---
@@ -46,25 +48,53 @@ export function waitForStalenessOf (_element ) {
}
export function loadTestData() {
--- End diff --
I think it is important that these test functions are commented and
documented. Not only for maintaining them, but they will possibly be examples
for other efforts.
Some of these functions around setting up tests and tearing them down would
themselves be useful as utility functions more general than the end to end
possibly
> Externalize the infrastructural components using integration tests
> ------------------------------------------------------------------
>
> Key: METRON-1344
> URL: https://issues.apache.org/jira/browse/METRON-1344
> Project: Metron
> Issue Type: Improvement
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> As we move towards adding the Alerts UI e2e test to our continuous build, we
> need to remove the dependence on vagrant full dev and provide equivalent
> infrastructure within Travis. This will include all the services that the
> e2e tests depend on including Kafka, Zookeeper, Elasticsearch (possibly
> HBase), and Metron REST.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
