[
https://issues.apache.org/jira/browse/METRON-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289341#comment-16289341
]
ASF GitHub Bot commented on METRON-1347:
----------------------------------------
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/863#discussion_r156676868
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -229,17 +239,30 @@ public void execute(Tuple tuple) {
LOG.trace("Writing enrichment message: {}", message);
WriterConfiguration writerConfiguration =
configurationTransformation.apply(
new IndexingWriterConfiguration(bulkMessageWriter.getName(),
getConfigurations()));
- if(writerConfiguration.isDefault(sensorType)) {
- //want to warn, but not fail the tuple
- collector.reportError(new Exception("WARNING: Default and (likely)
unoptimized writer config used for " + bulkMessageWriter.getName() + " writer
and sensor " + sensorType));
+ if(sensorType == null) {
--- End diff --
Strictly speaking that's true, but by convention original_string should be
required. There is a broader topic about what should be required, but that
certainly doesn't belong in a comment on a PR.
> Indexing Topology should fail tuples without a source.type
> ----------------------------------------------------------
>
> Key: METRON-1347
> URL: https://issues.apache.org/jira/browse/METRON-1347
> Project: Metron
> Issue Type: Bug
> Reporter: Casey Stella
>
> If you are sending data into metron indexing without a source.type, which
> would only happen if you're bypassing our previous topologies, we cannot
> configure how we write to the indices, so the message should be explicitly
> failed and reported.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
