[
https://issues.apache.org/jira/browse/METRON-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289946#comment-16289946
]
ASF GitHub Bot commented on METRON-1350:
----------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156788055
--- Diff: metron-analytics/metron-statistics/README.md ---
@@ -53,6 +53,32 @@ functions can be used from everywhere where Stellar is
used.
* bounds - A list of value bounds (excluding min and max) in sorted
order.
* Returns: Which bin N the value falls in such that bound(N-1) < value <=
bound(N). No min and max bounds are provided, so values smaller than the 0'th
bound go in the 0'th bin, and values greater than the last bound go in the M'th
bin.
+### Sampling Functions
+
+#### `SAMPLE_ADD`
+* Description: Add a value or collection of values to a sampler.
+* Input:
--- End diff --
This makes it seem like Uniform sampler is a 'known' thing. But it is not,
either by explanation or reference to where it is explained ( as we have done
referring to algorithms before ).
Is there another type of sampler?
Somewhere ( I'm not sure where ) we should say:
"A sampler is a xxxxx that is | does | acts as xxxxx for the sample
functions. The default has these properties, but you can override that in init"
Why even mention the Universal?
> Add reservoir sampling functions to Stellar
> -------------------------------------------
>
> Key: METRON-1350
> URL: https://issues.apache.org/jira/browse/METRON-1350
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
>
> Sampling capabilities would fit very well with the profiler and enable
> algorithms that do not necessarily support our existing probabilistic
> sketches. We should add a reservoir sampler and utilities to merge and
> resample.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
