[
https://issues.apache.org/jira/browse/METRON-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293382#comment-16293382
]
ASF GitHub Bot commented on METRON-1365:
----------------------------------------
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/871
METRON-1365: Allow PROFILE_GET to return a default value for a profile and
entity that does not have a value written.
## Contributor Comments
Right now the profiler is a sparse system, namely if data is not written
during a profile period for a given profile and entity, no values are written
to HBase. Some algorithms may need non-sparse data (e.g. time series outlier
detection algorithms). We should keep the default behavior as it stands, but
allow the user at read time to specify a default value. This is most cleanly
done by using the existing profiler config overrides (the 4rd argument to
`PROFILE_GET`) and adding a `profiler.default.value`.
You should be able to validate this in the REPL in full-dev by running:
```
PROFILE_GET('profile1', 'entity1', PROFILE_FIXED(4, 'HOURS'), {
'profiler.default.value' : 'metron'} )
```
You should see a list of strings with 16 or 17 copies of `metron` in it.
If you run it without the overrides, you should see an empty list returned.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron
profiler_default_values
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/871.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #871
----
commit f763a728bce19f10b49c2d431814e25006a5b5d3
Author: cstella <ceste...@gmail.com>
Date: 2017-12-15T22:37:22Z
Adding the ability to return default values from the profiler.
commit 44267b0850c7fc0912408f36badf64556a30d927
Author: cstella <ceste...@gmail.com>
Date: 2017-12-15T22:39:14Z
Updating readme to support default values
----
> Allow PROFILE_GET to return a default value for a profile and entity that
> does not have a value written.
> --------------------------------------------------------------------------------------------------------
>
> Key: METRON-1365
> URL: https://issues.apache.org/jira/browse/METRON-1365
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
>
> Right now the profiler is a sparse system, namely if data is not written
> during a profile period for a given profile and entity, no values are written
> to HBase. Some algorithms may need non-sparse data (e.g. time series outlier
> detection algorithms). We should keep the default behavior as it stands, but
> allow the user at read time to specify a default value. This is most cleanly
> done by using the existing profiler config overrides (the 3rd argument to
> PROFILE_GET) and adding a profiler.default.value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
