[
https://issues.apache.org/jira/browse/METRON-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302564#comment-16302564
]
ASF GitHub Bot commented on METRON-1339:
----------------------------------------
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r158588450
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationProvider.java
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to you under the
Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
the License. You may obtain
+ * a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.metron.common.configuration;
+
+import static
org.apache.metron.common.configuration.ConfigurationType.ENRICHMENT;
+import static
org.apache.metron.common.configuration.ConfigurationType.PARSER;
+import static
org.apache.metron.common.configuration.ConfigurationType.PROFILER;
+
+import java.util.LinkedList;
+import java.util.List;
+import org.apache.curator.framework.CuratorFramework;
+import
org.apache.metron.common.configuration.enrichment.SensorEnrichmentConfig;
+import org.apache.metron.common.configuration.profiler.ProfileConfig;
+import org.apache.metron.common.configuration.profiler.ProfilerConfig;
+import org.apache.metron.common.utils.JSONUtils;
+import
org.apache.metron.stellar.common.utils.validation.ExpressionConfigurationHolder;
+import
org.apache.metron.stellar.common.utils.validation.StellarConfigurationProvider;
+import
org.apache.metron.stellar.common.utils.validation.StellarConfiguredStatementContainer.ErrorConsumer;
+import org.apache.zookeeper.KeeperException.NoNodeException;
+
+/**
+ * {@code ConfigurationProvider} is used to report all of the configured /
deployed Stellar statements in
+ * the system.
+ */
+public class ConfigurationProvider implements StellarConfigurationProvider
{
+
+ /**
+ * Default constructor.
+ */
+ public ConfigurationProvider() {
+ }
+
+ @Override
+ public String getName() {
+ return "Apache Metron";
+ }
+
+ @Override
+ public List<ExpressionConfigurationHolder>
provideConfigurations(CuratorFramework client,
+ ErrorConsumer errorConsumer) {
+ List<ExpressionConfigurationHolder> holders = new LinkedList<>();
+ visitParserConfigs(client, holders, errorConsumer);
+ visitEnrichmentConfigs(client, holders, errorConsumer);
+ visitProfilerConfigs(client, holders, errorConsumer);
--- End diff --
I *think* you're right. Would suggest just a comment to clarify that point
and maybe help prompt us should that change
```
// indexing contains no stellar to validate
```
> Stellar Shell: Should have a way to validate deployed functions
> ---------------------------------------------------------------
>
> Key: METRON-1339
> URL: https://issues.apache.org/jira/browse/METRON-1339
> Project: Metron
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
>
> It is possible that the Stellar Language is changed during a release, meaning
> stellar expressions that are in zookeeper are now invalid, and will not run.
> Currently users cannot verify this without just letting them fail and hunting
> the errors down.
> The Stellar Shell should expose a '%' function that will verify that all
> stellar functions compile and are syntactically correct.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
