[
https://issues.apache.org/jira/browse/METRON-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314111#comment-16314111
]
ASF GitHub Bot commented on METRON-1382:
----------------------------------------
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/884
> Also, do we now have to validate in both environments when we make
changes to the shell? that should also be spelt out.
No you do not have to validate in both. The point of all this refactoring
was so that we don't have duplicate logic between the CLI REPL and Zeppelin.
(1) There is the `shell.StellarShell` that has all the Aesh code to drive
the CLI shell.
(2) There is the `zeppelin.StellarInterpreter` that has all the logic to
interact with Zeppelin.
(3) Finally there is the `shell.StellarShellExecutor` that is used by both
(1) and (2) to handle Stellar and our Stellar "extensions" like assignment,
comments, etc.
All of this now has a plethora of unit tests; tests that we didn't have
before. So I think this puts us in a better position to avoid future
regressions.
> Run Stellar in a Zeppelin Notebook
> ----------------------------------
>
> Key: METRON-1382
> URL: https://issues.apache.org/jira/browse/METRON-1382
> Project: Metron
> Issue Type: Improvement
> Reporter: Nick Allen
> Assignee: Nick Allen
>
> Create a Zeppelin interpreter that allows Stellar to run in a Zeppelin
> Notebook, the same way that it runs in the command-line driven REPL.
> This should include all of the Stellar "enhancements" available in the REPL
> that are not part of the core Stellar language including the following.
> * Variable assignment
> * Magics
> * Docstrings
> * Comments
> * quit
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
