[
https://issues.apache.org/jira/browse/METRON-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316661#comment-16316661
]
ASF GitHub Bot commented on METRON-1378:
----------------------------------------
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/879#discussion_r160208209
--- Diff:
metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/nonbulk/flatfile/writer/Writer.java
---
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.dataloads.nonbulk.flatfile.writer;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.metron.common.utils.SerDeUtils;
+
+import java.io.IOException;
+import java.util.Optional;
+
+public interface Writer {
+ void validate(Optional<String> output, Configuration hadoopConfig);
--- End diff --
Why doesn't this either return something or throw a checked exception?
Right now the validate method is just something that you call and it doesn't do
anything except throw runtime exception in the impls, rather than giving the
caller an explicit ability to do anything about the validation failure.
> Create a summarizer
> -------------------
>
> Key: METRON-1378
> URL: https://issues.apache.org/jira/browse/METRON-1378
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
>
> We have a nice and generalized infrastructure for loading data into HBase and
> interacting with it via `flatfile_loader.sh` and `ENRICHMENT_GET()`. It is
> also useful to summarize a set of data into a static data structure, store it
> on HDFS and interact with it via stellar. To this end, to complement the
> `flatfile_loader.sh`, we should have a `flatfile_summarizer.sh` that, using
> the same extractor config, will process a flat file and output a serialized
> object.
> The usecase for this is as follows:
> Let's say that I have a static list of domains in the second column of a CSV,
> domains.csv, and I want to generate a bloom filter with those domains in them
> sans TLD.
> I should be able to create a file called `bloom.ser` with the serialized
> bloom filter given the extractor config:
> {code}
> {
> "config" : {
> "columns" : {
> "rank" : 0,
> "domain" : 1
> },
> "value_transform" : {
> "domain" : "DOMAIN_REMOVE_TLD(domain)"
> },
> "value_filter" : "LENGTH(domain) > 0",
> "state_init" : "BLOOM_INIT()",
> "state_update" : {
> "state" : "BLOOM_ADD(state, domain)"
> },
> "state_merge" : "BLOOM_MERGE(states)",
> "separator" : ","
> },
> "extractor" : "CSV"
> }
> {code}
> Note, the associated stellar function `OBJECT_GET` is pending.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
