[
https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331029#comment-16331029
]
ASF GitHub Bot commented on METRON-1090:
----------------------------------------
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/687
I have not looked at the code yet, but wanted to comment on the assignment
discussion. IMO focusing on user experience is the way to go. To that end...
* We should use `=` because that is just more obvious.
* We should remove `:=` from the REPL environment (very easy, just delete
`AssignmentCommand`).
* All references in the docs to `:=` need to be changed to `=`. (Ugh)
All of that can happen in this PR or as multiple PRs (however
@ottobackwards sees fit), but that is the right end state.
**Alternative Option**: The only other reasonable option IMO is to support
both `=` and `:=` (for some undetermined period of time.) The only snafu is
that both should have the same implementation. So support for `:=` would have
to be added to the 'language' and we should NOT rely on the `AssignmentCommand`
implementation in the REPL.
I am mildly against the "Alternative Option", but wanted to offer it up for
discussion.
> STELLAR Add Assignment capability to Stellar language
> -----------------------------------------------------
>
> Key: METRON-1090
> URL: https://issues.apache.org/jira/browse/METRON-1090
> Project: Metron
> Issue Type: New Feature
> Reporter: Otto Fowler
> Assignee: Otto Fowler
> Priority: Major
>
> Add support for =, +=, -=, *=, /= for variables in stellar.
> foo = 5 returns 5 AND sets foo to 5 if the VariableResolver supports it.
> The shell should be changed to assign variables using this syntax, because
> exposing the left side to stellar allows catching errors for invalid keywords
> in left side.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
