[
https://issues.apache.org/jira/browse/METRON-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339724#comment-16339724
]
ASF GitHub Bot commented on METRON-1430:
----------------------------------------
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/910
This looks awesome at first look. I'm a big fan of doing this regardless
of the shading issue. The only thought that comes to mind is that there is a
tipping point where a *Utils class isn't the right thing, that is it outgrown.
I feel like we might be there for JSONUtils.
We can do that in another pr however I guess.
> Isolate jackson from being used as arguments or returns from JSONUtils
> ----------------------------------------------------------------------
>
> Key: METRON-1430
> URL: https://issues.apache.org/jira/browse/METRON-1430
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
> Priority: Major
>
> Currently jackson is used as part of our internal API to JSONUtils. The
> problem here is when we shade and relocate jackson. Suddenly we can't use
> JSONUtils. We should avoid operating on jackson primitives and rather
> provide a convenient wrapper around the places where we use jackson as part
> of the API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
