ASF GitHub Bot commented on METRON-1438:

Github user ottobackwards commented on a diff in the pull request:

    --- Diff: 
    @@ -40,8 +45,8 @@
       Context context = new Context.Builder()
    -            .with(Context.Capabilities.SHELL_VARIABLES , () -> variables)
    -            .build();
    +            .with(Context.Capabilities.SHELL_VARIABLES , () -> 
    --- End diff --
    I didn't reformat that like that on purpose.  I had a period where I was 
setting the CONSOLE capability.  When I removed it, it just worked out like 
    Even if I select and format in intellij it doesn't change the .build() to 
the next line.
    I think what you have above is fine.  I would like it to 'just' happen if I 
format code though, since it is easy for things to slip through.
    It is tough right now, because so much of the codebase isn't formatted to 
check style, and I don't think we want every pr to include a lot of formatting 

> STELLAR: Move shell functions to common from metron-management
> --------------------------------------------------------------
>                 Key: METRON-1438
>                 URL: https://issues.apache.org/jira/browse/METRON-1438
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major

This message was sent by Atlassian JIRA

Reply via email to