[ 
https://issues.apache.org/jira/browse/METRON-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355709#comment-16355709
 ] 

ASF GitHub Bot commented on METRON-1448:
----------------------------------------

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/929#discussion_r166682417
  
    --- Diff: 
metron-platform/metron-solr/src/main/java/org/apache/metron/solr/writer/SolrWriter.java
 ---
    @@ -33,17 +39,19 @@
     
     import java.io.IOException;
     import java.io.Serializable;
    -import java.util.List;
    -import java.util.Map;
    +import java.lang.invoke.MethodHandles;
    +import java.util.*;
    --- End diff --
    
    You got it :)


> Update SolrWriter to conform to new collection strategy
> -------------------------------------------------------
>
>                 Key: METRON-1448
>                 URL: https://issues.apache.org/jira/browse/METRON-1448
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>            Priority: Major
>
> Currently the SolrWriter presumes a single collection to be written to.  The 
> new collection strategy for Solr implies a collection per sensor.  Also, 
> there are a few rough edges in the writer which could stand smoothing:
>  * By default, we use solr's implicit commit mechanism, rather than 
> committing at the batch granularity.  This may result in lost data on worker 
> failure.
>  * We do not use the the batch add api, but rather message-by-message add



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to