[ 
https://issues.apache.org/jira/browse/METRON-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373669#comment-16373669
 ] 

ASF GitHub Bot commented on METRON-1337:
----------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/853#discussion_r170125479
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
 ---
    @@ -37,15 +47,21 @@
     @Service
     public class AlertServiceImpl implements AlertService {
     
    --- End diff --
    
    I think that is great.  At some point, if we are going to do this a few 
times we should have a standard naming convention ( separators at least or 
something).  But that isn't a thing for this PR


> List of facets should not be hardcoded
> --------------------------------------
>
>                 Key: METRON-1337
>                 URL: https://issues.apache.org/jira/browse/METRON-1337
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>            Priority: Major
>
> Currently the facet fields shown in the left panel of the Alerts UI is hard 
> coded in a javascript file.  This should be configurable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to