ASF GitHub Bot commented on METRON-1423:

Github user cestella commented on a diff in the pull request:

    --- Diff: metron-platform/metron-solr/src/main/scripts/create_collection.sh 
    @@ -0,0 +1,27 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    --- End diff --
    I notice that we're depending on maven artifacts of 6.6.0 and we set the 
solr version to 6.6.2 here, is there a reason for that?  If we can align them, 
then we could replace this line with SOLR_VERSION=`${global_solr_version}`
    This question applies for the rest of the shell scripts too

> Ambari work to handle Solr configuration
> ----------------------------------------
>                 Key: METRON-1423
>                 URL: https://issues.apache.org/jira/browse/METRON-1423
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Justin Leet
>            Assignee: Ryan Merriman
>            Priority: Major
> Ambari needs to be able to handle Solr configuration. This should be setup 
> similar to the existing ES config screen, and include anything necessary to 
> plug in a generic Solr connection.

This message was sent by Atlassian JIRA

Reply via email to