[ 
https://issues.apache.org/jira/browse/METRON-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375044#comment-16375044
 ] 

ASF GitHub Bot commented on METRON-1462:
----------------------------------------

GitHub user mmiklavc opened a pull request:

    https://github.com/apache/metron/pull/943

    METRON-1462: Separate ES and Kibana from Metron Mpack

    ## Contributor Comments
    
    This splits ES and Kibana into their own MPacks. Two comments for reviewers:
    - The original discuss thread mentioned putting this in metron-contrib. Are 
we dead set on this, or is my split in metron-deployment reasonable?
    - I kept the Kibana templates and associated documentation in their current 
location and migrated them with the Kibana service. This is consistent with our 
current deployment and means we don't need to add a new set of features to the 
Metron MPack to publish them. A point in favor of moving this to Metron's MPack 
would be that we think this is in the purview of Metron and would make the 
Ambari design more consistent when we introduce Solr.
    
    **Testing**
    Spin up full dev and verify the Kibana dashboard is displaying information.
    
    ## Pull Request Checklist
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mmiklavc/metron es-mpack-split

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #943
    
----
commit f266600bf67dd11974a4c5faff7120c1b1044629
Author: Michael Miklavcic <michael.miklavcic@...>
Date:   2018-02-21T16:58:42Z

    Ready to test ES/Kibana MPack split. TODO: README updates

commit 941e767287e403873d893a304b5847033e4c9b16
Author: Michael Miklavcic <michael.miklavcic@...>
Date:   2018-02-21T16:59:55Z

    Merge branch 'master' into es-mpack-split

commit 96e4b6188b04a5518064a9a1cd59aeaf3059cdc1
Author: Michael Miklavcic <michael.miklavcic@...>
Date:   2018-02-23T21:40:03Z

    Document the ES and Kibana MPack split

----


> Separate ES and Kibana from Metron Mpack
> ----------------------------------------
>
>                 Key: METRON-1462
>                 URL: https://issues.apache.org/jira/browse/METRON-1462
>             Project: Metron
>          Issue Type: Sub-task
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>            Priority: Major
>
> Need this to enable our ability to provide pluggable Solr support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to