[ https://issues.apache.org/jira/browse/METRON-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376900#comment-16376900 ]
ASF GitHub Bot commented on METRON-1461: ---------------------------------------- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/942#discussion_r170598354 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/Ordinal.java --- @@ -0,0 +1,24 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.metron.stellar.dsl.functions; + +public interface Ordinal { --- End diff -- Can you add javadocs for the class and each method? > MIN MAX stellar function should take a stats or list object and return min/max > ------------------------------------------------------------------------------ > > Key: METRON-1461 > URL: https://issues.apache.org/jira/browse/METRON-1461 > Project: Metron > Issue Type: Bug > Reporter: Mohan > Assignee: Mohan > Priority: Minor > > Currently the MIN and MAX stellar function accepts only the list as input > and the list may only contain objects that are mutually comparable / ordinal. > Modify the method to take a stats or list object and return min/max. > * [|https://hortonworks.jira.com/secure/AddComment!default.jspa?id=163485] -- This message was sent by Atlassian JIRA (v7.6.3#76005)