ASF GitHub Bot commented on METRON-1471:

GitHub user cestella opened a pull request:


    METRON-1471: Migrate shuffle connections to local or shuffle

    ## Contributor Comments
    Currently, we use shuffle groupings when we do not want to group by field.  
We should, instead, use local or shuffle groupings.
    Manual tests should include ensuring data continues to flow as before.
    ## Pull Request Checklist
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
 for complete smoke testing guides.  
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      mvn -q clean integration-test install && 
    - [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron 

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #949
commit 0ab26fa172a90eaf8eb441c8c085308649efdfb9
Author: cstella <cestella@...>
Date:   2018-03-06T16:18:57Z

    Updating the rest of the topologies to prefer local or shuffle over shuffle


> Migrate shuffle connections to local or shuffle
> -----------------------------------------------
>                 Key: METRON-1471
>                 URL: https://issues.apache.org/jira/browse/METRON-1471
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>            Priority: Major
> Currently, we use shuffle groupings when we do not want to group by field.  
> We should, instead, use local or shuffle groupings.

This message was sent by Atlassian JIRA

Reply via email to