[ 
https://issues.apache.org/jira/browse/METRON-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389497#comment-16389497
 ] 

ASF GitHub Bot commented on METRON-1472:
----------------------------------------

GitHub user xyztdanid4 opened a pull request:

    https://github.com/apache/metron/pull/953

    Metron 1472 Add stylelint support

    THIS IS WIP. FIRST #952 SHOULD MERGED.
    
    Added support for stylelint to be able to validate scss syntax.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at 
[https://issues.apache.org/jira/browse/METRON-1472](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [X] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [X] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xyztdanid4/metron METRON-1472

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #953
    
----
commit 0812c6eca0bc009ddd0658f7976f5734daedb859
Author: Daniel Toth <dtoth@...>
Date:   2018-03-07T10:40:01Z

    Add yarn as build tool

commit 9117dac298a42a0b434ab933354a54542724b6bc
Author: Daniel Toth <dtoth@...>
Date:   2018-03-07T11:47:50Z

    Update ts to avoid 'app module is not an ng module error on build'

commit f5a8521552db0a3f0b5e7c11ff26c42241edf5d4
Author: Daniel Toth <dtoth@...>
Date:   2018-03-07T12:30:37Z

    Add stlyelint support

----


> Add stylelint support
> ---------------------
>
>                 Key: METRON-1472
>                 URL: https://issues.apache.org/jira/browse/METRON-1472
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Daniel Toth
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Add stylelint support for better code quality



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to