ASF GitHub Bot commented on METRON-1474:

GitHub user xyztdanid4 opened a pull request:


    METRON-1474 Add normalizecss

    ## Contributor Comments
    This PR adds normalizecss to the frontend projects. It is useful to bridge 
the differences between browsers.
    ## Pull Request Checklist
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
 for complete smoke testing guides.  
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at 
    - [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [X] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      mvn -q clean integration-test install && 
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
    - [X] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
      cd site-book
      mvn site
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xyztdanid4/metron METRON-1474

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #955
commit 0812c6eca0bc009ddd0658f7976f5734daedb859
Author: Daniel Toth <dtoth@...>
Date:   2018-03-07T10:40:01Z

    Add yarn as build tool

commit 9117dac298a42a0b434ab933354a54542724b6bc
Author: Daniel Toth <dtoth@...>
Date:   2018-03-07T11:47:50Z

    Update ts to avoid 'app module is not an ng module error on build'

commit c4bef1662835051db430d657b479691f137d34ec
Author: Daniel Toth <dtoth@...>
Date:   2018-03-07T13:44:29Z

    Add normalize css to the frontend


> Add normalizecss
> ----------------
>                 Key: METRON-1474
>                 URL: https://issues.apache.org/jira/browse/METRON-1474
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Daniel Toth
>            Priority: Minor
> Add normalizecss to reduce css mistakes

This message was sent by Atlassian JIRA

Reply via email to