[ 
https://issues.apache.org/jira/browse/METRON-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395848#comment-16395848
 ] 

ASF GitHub Bot commented on METRON-1483:
----------------------------------------

Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/958#discussion_r173926217
  
    --- Diff: 
metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/monitor/AbstractMonitor.java
 ---
    @@ -0,0 +1,49 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.performance.load.monitor;
    +
    +import java.util.Optional;
    +import java.util.function.Supplier;
    +
    +public abstract class AbstractMonitor implements Supplier<Long>, 
MonitorNaming {
    +  private static final double EPSILON = 1e-6;
    +  protected Optional<?> kafkaTopic;
    +  protected long timestampPrevious = 0;
    +  public AbstractMonitor(Optional<?> kafkaTopic) {
    +    this.kafkaTopic = kafkaTopic;
    +  }
    +
    +  protected abstract Long monitor(double deltaTs);
    +
    +  @Override
    +  public Long get() {
    +    long timeStarted = System.currentTimeMillis();
    --- End diff --
    
    I'd probably use `System.nanoTime` here (if it's not going to cause perf 
issues).  `System.currentTimeMillis` is, iirc, subject entirely to the system 
clock, which can be hit with daylight savings time and such.


> Create a tool to monitor performance of the topologies
> ------------------------------------------------------
>
>                 Key: METRON-1483
>                 URL: https://issues.apache.org/jira/browse/METRON-1483
>             Project: Metron
>          Issue Type: New Feature
>            Reporter: Casey Stella
>            Priority: Major
>
> In performance evaluation, generating synthetic load and monitoring the write 
> throughput of our kafka-to-kafka topologies has required a lot of custom 
> scripting.  We should have a tool that could do the following:
>  * Take a file representing a message template and generate synthetic load at 
> a given events per second
>  * Monitor the kafka offsets of a topic and report throughput numbers in 
> events per second
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to