[ 
https://issues.apache.org/jira/browse/METRON-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400469#comment-16400469
 ] 

ASF GitHub Bot commented on METRON-1491:
----------------------------------------

GitHub user cestella opened a pull request:

    https://github.com/apache/metron/pull/964

    METRON-1491: The indexing topology restart logic is wrong

    ## Contributor Comments
    If either topology is down, Ambari shows all of Indexing as dead. Clicking 
start attempts to start them both and fails if either is still running. 
Furthermore, it appears to retry 3 times before finally failing the command.
    
    In order to test this, kill one of the indexing topologies then attempt to 
start indexing from ambari.  Things should go smoothly.  Also, try restarting 
and starting in various states.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron METRON-1491

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #964
    
----
commit 423e9a074492ae2071022b9a4adb347d2a109633
Author: cstella <cestella@...>
Date:   2018-03-15T14:27:09Z

    METRON-1491: The indexing topology restart logic is wrong

----


> The indexing topology restart logic is wrong
> --------------------------------------------
>
>                 Key: METRON-1491
>                 URL: https://issues.apache.org/jira/browse/METRON-1491
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Casey Stella
>            Priority: Major
>
> If either topology is down, Ambari shows all of Indexing as dead. Clicking 
> start attempts to start them both and fails if either is still running. 
> Furthermore, it appears to retry 3 times before finally failing the command.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to