[
https://issues.apache.org/jira/browse/METRON-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404763#comment-16404763
]
ASF GitHub Bot commented on METRON-1497:
----------------------------------------
GitHub user MohanDV opened a pull request:
https://github.com/apache/metron/pull/968
METRON-1497: Rest endpoint '/api/v1/search/search' needs to handle null
when elastic search response return null for getAggregations
## Contributor Comments
Handle null value when elastic search response return null for
getAgreegations method
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MohanDV/metron METRON-1497
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/968.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #968
----
commit f417510d232d0f1b4fde72ed89a53fab30d7dc69
Author: Mohan Venkateshaiah <mohan.dv@...>
Date: 2018-03-19T12:49:29Z
Handle null value when elastic search response return null for
getAggregations method
----
> Rest endpoint '/api/v1/search/search' needs to handle null when elastic
> search response return null for getAggregations
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: METRON-1497
> URL: https://issues.apache.org/jira/browse/METRON-1497
> Project: Metron
> Issue Type: Bug
> Reporter: Mohan
> Assignee: Mohan
> Priority: Major
>
> /api/v1/search/search throws null pointer exception as below when you have
> fresh deployment with no indices created .
> {code:java}
> {
> "timestamp": "2018-03-19 11:42:11",
> "status": 500,
> "error": "Internal Server Error",
> "exception": "java.lang.NullPointerException",
> "message": "No message available",
> "path": "/api/v1/search/search"
> }
> {code}
> below is the pay load
> {code:java}
> {
> "indices": [],
> "query": "*",
> "from": 0,
> "size": 10,
> "sort": [
> {
> "field": "timestamp",
> "sortOrder": "desc"
> }
> ],
> "facetFields": []
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
