[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411690#comment-16411690
]
ASF GitHub Bot commented on METRON-1421:
----------------------------------------
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/970
Thanks @justinleet for consuming my rant. :)
I agree with most of what you're saying. I'm perfectly happy iterating
improvements on this. And totally willing to help. One disagreement...
> For the specific calculating metascores case, and probably some of the
other stuff, it only seems useful to break that sort of thing into it's own
class if we intend on making it pluggable.
I disagree here. Making things pluggable, even if we now currently only
have one type of plug, is still beneficial. It is going to help make it more
testable and shrink the square footage of that class.
> Create a SolrMetaAlertDao
> -------------------------
>
> Key: METRON-1421
> URL: https://issues.apache.org/jira/browse/METRON-1421
> Project: Metron
> Issue Type: Sub-task
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Major
>
> Create an implementation of the MetaAlertDao for Solr. This will involve
> implementing the various MetaAlertDao methods using the SolrJ library and
> also providing a SolrMetaAlertIntegrationTest (similar to
> ElasticsearchMetaAlertIntegrationTest).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
