[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432818#comment-16432818
]
ASF GitHub Bot commented on METRON-1518:
----------------------------------------
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/986
METRON-1518 Build Failure When Using Profile HDP-2.5.0.0
The build fails when using the 'HDP-2.5.0.0' profile.
```
/Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:45:
error: cannot find symbol
import org.apache.storm.StormTimer;
^
symbol: class StormTimer
location: package org.apache.storm
/Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:167:
error: cannot find symbol
private StormTimer expiredFlushTimer;
^
symbol: class StormTimer
location: class ProfileBuilderBolt
/Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:450:
error: cannot find symbol
private StormTimer createTimer(String name) {
^
symbol: class StormTimer
location: class ProfileBuilderBolt
```
This was caused by my PR; #977. That code relied on a class that is only
available in Storm 1.0.3+. When using the Maven profile `HDP-2.5.0.0`, the
code is built against Storm 1.0.1.
### Changes
* This completely removes the use of a`StormTimer`. There is no need for
it. I had thought it would help me drive testing, but it has not ended up
being useful at all.
* An executor is used to drive a separate thread which flushes expired
profiles on a regular basis.
* Updated the Travis CI builds so they are run with the HDP-2.5.0.0
profile. This ensures that the CI tests are run against the same version of
Storm as the development environments are built against. This will help ensure
we catch similar issues in the future.
### Manual Testing
* Run a development environment and ensure that alerts are visible in the
Alerts UI.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1518
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/986.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #986
----
commit 0c012fc8cfa6314dfc30c7d372970f1d68bfd908
Author: Nick Allen <nick@...>
Date: 2018-04-10T12:46:47Z
METRON-1518 Build Failure When Using Profile HDP-2.5.0.0
----
> Build Failure When Using Profile HDP-2.5.0.0
> --------------------------------------------
>
> Key: METRON-1518
> URL: https://issues.apache.org/jira/browse/METRON-1518
> Project: Metron
> Issue Type: Bug
> Reporter: Nick Allen
> Assignee: Nick Allen
> Priority: Major
>
> {code}
> /Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:45:
> error: cannot find symbol
> import org.apache.storm.StormTimer;
> ^
> symbol: class StormTimer
> location: package org.apache.storm
> /Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:167:
> error: cannot find symbol
> private StormTimer expiredFlushTimer;
> ^
> symbol: class StormTimer
> location: class ProfileBuilderBolt
> /Users/ottofowler/src/apache/forks/metron/metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java:450:
> error: cannot find symbol
> private StormTimer createTimer(String name) {
> ^
> symbol: class StormTimer
> location: class ProfileBuilderBolt
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
