Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/995#discussion_r182277467
--- Diff:
metron-platform/metron-solr/src/test/java/org/apache/metron/solr/dao/SolrUpdateDaoTest.java
---
@@ -132,4 +134,19 @@ public void
batchUpdateShouldProperlyUpdateDocumentsWithoutIndex() throws Except
verify(client).add(argThat(new
SolrInputDocumentListMatcher(Arrays.asList(snortSolrInputDocument1,
snortSolrInputDocument2))));
}
+ @Test
+ public void toSolrInputDocumentShouldProperlyReturnSolrInputDocument() {
--- End diff --
Can you make this something like
`toSolrInputDocumentShouldIgnoreLocationSubfields` to make it more obvious
what's being expected?
---
