GitHub user sardell opened a pull request:
https://github.com/apache/metron/pull/1004
METRON-1489: Retrofit UI tests to run reliably during nightly QE runs
## Contributor Comments
This Pull Request includes work started by @iraghumitra on his branch
`e2e-using-await-1`. In addition to the asyn/await work he did, I added
[protractor-flake](https://github.com/NickTomlin/protractor-flake) in order to
re-run failing tests to ensure they are actual failures and not the result of
flakey tests.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sardell/metron METRON-1489
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1004.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1004
----
commit e17336a7f89756d822f6c7c776d865c0214683da
Author: iraghumitra <raghumitra.ksv@...>
Date: 2018-04-26T09:07:57Z
Initial commit for e2e tests in new branch
commit 15e379e6ca1b98fe9c5e59ff7d4d777afd072e63
Author: Shane Ardell <sardell@...>
Date: 2018-04-27T10:49:25Z
METRON-1489: fix test to account for leap year days
commit be90636a5d5ecefdd4469986b1ca1a2878942fd4
Author: Shane Ardell <sardell@...>
Date: 2018-04-27T11:06:16Z
METRON-1489: fix flakey test results with protractor-flake
----
---
