[ 
https://issues.apache.org/jira/browse/METRON-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463390#comment-16463390
 ] 

ASF GitHub Bot commented on METRON-1233:
----------------------------------------

Github user DimDroll commented on the issue:

    https://github.com/apache/metron/pull/789
  
    @mmiklavc , I still don't see anything helpful specified about enrichment 
in here:
    
https://metron.apache.org/current-book/metron-platform/metron-common/index.html
    I guess we can reference enrichment configuration in global configuration, 
but I still don't see sense of mentioning Global configuration in Enrichment 
section without anything relevant to enrichment in Global configuration.


> Remove description of Global configuration from Enrichment doc
> --------------------------------------------------------------
>
>                 Key: METRON-1233
>                 URL: https://issues.apache.org/jira/browse/METRON-1233
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Dima Kovalyov
>            Priority: Minor
>
> It confuses reader. Description of Global configuration is available ahead of 
> the enrichment and listed here:
> https://metron.apache.org/current-book/metron-platform/metron-common/index.html
> Global config is used for validation of the fields.
> Enrichment is used for fields enrichment and probably can also be used for 
> validation of the fields (which is not covered in the doc).
> From available doc I can see that they serve two different purposes.
> So, I don't see any reason to mention global config in enrichment 
> description. What's the benefit of knowing about global configuration when 
> you want deep dive in enrichment?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to