Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1009#discussion_r187404078
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/writers/integration/WriterBoltIntegrationTest.java
---
@@ -166,6 +185,139 @@ public void test() throws UnableToStartException,
IOException, ParseException {
}
}
+ /**
+ * {
+ *
"parserClassName":"org.apache.metron.writers.integration.WriterBoltIntegrationTest$EmptyObjectParser",
+ * "sensorTopic":"emptyobjectparser",
+ * "outputTopic": "enrichments",
+ * "errorTopic": "parser_error"
+ * }
+ */
+ @Multiline
+ public static String offsetParserConfigJSON;
+
+ @Test
+ public void commits_kafka_offsets_for_emtpy_objects() throws Exception {
--- End diff --
No doubt I've seen it done in other code bases. Its just not common in the
Metron code base, thus I called it out.
Since it doesn't violate the code style guidelines, then I have no basis to
complain. I wasn't aware that was acceptable. Thanks for clarifying.
---
