[
https://issues.apache.org/jira/browse/METRON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472823#comment-16472823
]
ASF GitHub Bot commented on METRON-1552:
----------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1011
METRON-1552: Add gzip file validation check to the geo loader
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1552
We don't have retries implemented in the loader, so network and other type
of failures will cause the download to blow up. This adds default retries to
the loader that can be overridden by the cli options passed to the loader.
I need to finish manual testing, but putting it out there. Also added a
compression strategy class to metron-common to handle the validity check.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
n/a
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron add-geo-file-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1011.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1011
----
commit 8421dea9f27bc899cd202801d5dc9c6d238dde0f
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-05-12T00:14:42Z
Add check for Geo database file
----
> Add gzip file validation check to the geo loader
> ------------------------------------------------
>
> Key: METRON-1552
> URL: https://issues.apache.org/jira/browse/METRON-1552
> Project: Metron
> Issue Type: Improvement
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
